Percona Toolkit 2.1.9 bug raffle

Percona Toolkit 2.1.9 bug raffle

Since we’re very busy working on Percona Toolkit 2.2 and other projects, I thought 2.1.8 (the current latest Percona Toolkit release) would be the last release in that series, but it introduced a new bug in pt-heartbeat (despite all the tool’s tests) that I’d like to fix.

A single bug fix is probably underkill for a full release (unless it’s a hotfix), so for 2.1.9 let’s fix whatever you want–our first* ever “bug raffle.”

“Space is limited”, so we can only take only take on a few bugs (let’s say 10 at most), depending on their complexity and ability to be reproduced.  If you have a bug** you wanted fixed in 2.1.9, please give its link in a comment.

I’ll go first: https://bugs.launchpad.net/percona-toolkit/+bug/1099665

* Maybe not the first: I have a vague memory of doing something similar for Maatkit.
** An actual bug, not a feature request.

11 Comments
Oldest
Newest Most Voted
Inline Feedbacks
View all comments
Daniel Nichter

Joe, sure, we’ll look into it. However, it may not be possible to detect all types of connection errors. In the case of “telnet mysql 3306”, I think what we’ll see is: MySQL will send its handshake to the client, the client won’t respond, so MySQL will give up and close the connection. The tool can and does see server handshakes, but I’m not sure what happens if nothing happens beyond that. Off the top of my head, I bet the code is currently saving the (failed) session forever, waiting for it to complete.

0
Ernie Souhrada

This one was kind of a pain in my rear on a recent engagement. Allow me to tell pt-stalk to shut up, please! 🙂

https://bugs.launchpad.net/percona-toolkit/+bug/1099933

0
Daniel Nichter

Ernie, aye, will do. 🙂

0
Daniel Nichter

Fernando, sure, I’ll look into that.

Ovais, I do plan to fix that pt-os bug. For the bug, do you have some sample LVM output?

0
Ovais Tariq

Daneil,

Re 1086365, I will have to see if I have LVM running somewhere to provide a sample output, but I think the output of pvs and lvs should be enough.

0
Raghavendra

I would go with https://bugs.launchpad.net/percona-toolkit/+bug/1050654 and https://bugs.launchpad.net/percona-toolkit/+bug/1083488 , though the NUMA one is not that urgent.

Even though https://bugs.launchpad.net/percona-toolkit/+bug/1031427 is not reported by me, I would go with that since package installation problems can be major hindrance

https://bugs.launchpad.net/percona-toolkit/+bug/1015230 , though closed as ‘feature-request’, would be nice to have in some version. (We get repeated requests over this and using a user with toolkit with elevated privileges is not wise).

0
Daniel Nichter

Thanks to everyone who replied. I think everyone, except Fernando, got something in this release.

Ragu: those build bugs are a very high priority for me and the build team. I basically told them, “do whatever is correct/works.” As you know, it’s not a simple fix on on their side, but we’ll see if 2.1.9 is better and, if not, we’ll make a stronger push for 2.2.

Fernando, I targeted your bug for 2.2. Sorry, I just didn’t have time to implement something like that.

0
Daniel Nichter

Percona Toolkit 2.1.9 has been released: http://www.mysqlperformanceblog.com/2013/02/15/percona-toolkit-2-1-9-is-ready/

0